Add additional safelist regex variations#7674
Closed
mrinx wants to merge 2 commits intotailwindlabs:masterfrom
Closed
Add additional safelist regex variations#7674mrinx wants to merge 2 commits intotailwindlabs:masterfrom
mrinx wants to merge 2 commits intotailwindlabs:masterfrom
Conversation
Member
|
Awesome thank you! I made a couple small tweaks to remove support for this option: safelist: [
{
pattern: [['hover'], /bg-(red)-(100|200)/, ['50']],
pattern: [['hover'], /bg-(green)-(100|200)/],
pattern: [/bg-(blue)-(100|200)/, ['50']],
pattern: [/bg-(yellow)-(100|200)/],
},
],...just because thinking about it again I just don't see a reason to support it, better to just use the top-level tuple format. Going to review this idea with the team this week before merging but I think this is going to be an improvement, thanks again. |
Member
|
Hey thanks again for this! Decided on a slightly different approach which we've opened a PR for here: So going to close this, but included you as a co-author on that one for your efforts here ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is trying to bring a new way of doing regex safelisting, and to allow for color opacities in a safelist with regex (#6770).
The current format:
The new formats:
@adamwathan, is this something you had in mind (#7582)?